fungus

Open full view…

Is this a bug in the ConversationManager?

academyoff
Thu, 12 Sep 2019 23:10:09 GMT

I noticed the ConversationManager has code like this: --- if (sayParams == null || sayParams.Length == 0) { // Text only, no params - early out. return item; } --- This is near the top of `CreateConversationItem`. It seems to me that before the return, it should be setting `item.Character = currentCharacter;` Because it doesn't, I believe conversations work like this: --- Eva: Hi! : On this line, the current character is Eva : On this line, there is no current character! --- If that's intended behavior, I don't understand why it would be preferred. Can someone explain this to me?

Steve Halliwell
Fri, 13 Sep 2019 22:00:03 GMT

The existing conversation samples don't use an empty leading direction. Can you confirm the bug in your situation with and without the leading : on lines that don't have stage direction

academyoff
Sat, 14 Sep 2019 00:06:49 GMT

Yeah I checked and it still happens regardless.